Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/Eligibility Report JAC Comments #2482

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Hotfix/Eligibility Report JAC Comments #2482

merged 1 commit into from
Jul 9, 2024

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Jul 9, 2024 •
edited
Loading

What's included?

Rename Reasons not satisfied to JAC comments in the Eligibility Report.

Who should test?

✅ Product owner
✅ Developers

How to test?

Example exercise on Production: https://jac-apply-admin-production--pr2482-hotfix-eligibility-m6wiapsd.web.app/exercise/IiaXjmpDQd7BQx7ovlv0/reports/eligibility-issues

  1. Go to Eligibility Report
  2. Check if Reasons not satisfied has been renamed to JAC comments

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:PRODUCTION
can be OFF, DEVELOP or STAGING

@HalcyonJAC HalcyonJAC self-assigned this Jul 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 8675d8b):

https://jac-apply-admin-production--pr2482-hotfix-eligibility-m6wiapsd.web.app

(expires Thu, 08 Aug 2024 08:26:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2f31b7832d58b04f07d3816f45a5d09d461ded5e

@HalcyonJAC HalcyonJAC marked this pull request as ready for review July 9, 2024 08:23
@HalcyonJAC HalcyonJAC requested review from a team as code owners July 9, 2024 08:23
@HalcyonJAC HalcyonJAC requested review from NormaJAC, tomlovesgithub, drieJAC, KoWeiJAC and nickaddy and removed request for KoWeiJAC July 9, 2024 08:23
nickaddy
nickaddy approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HalcyonJAC Thanks for the quick response 👍

@HalcyonJAC HalcyonJAC merged commit a05b7d6 into main Jul 9, 2024
9 checks passed
@HalcyonJAC HalcyonJAC deleted the hotfix/eligibility-report-jac-comments branch July 9, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickaddy nickaddy nickaddy approved these changes

@NormaJAC NormaJAC Awaiting requested review from NormaJAC NormaJAC is a code owner automatically assigned from jac-uk/jac-product

@tomlovesgithub tomlovesgithub Awaiting requested review from tomlovesgithub tomlovesgithub is a code owner automatically assigned from jac-uk/jac-developers

@drieJAC drieJAC Awaiting requested review from drieJAC drieJAC is a code owner automatically assigned from jac-uk/drie

Assignees

@HalcyonJAC HalcyonJAC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HalcyonJAC @nickaddy